BDMS 389: fixes#293
Merged
Merged
Conversation
Fix the special request notes for a contact Fix adding a ContantThingAssociation in contact_helper.py Keep well_purposes in the thing data
jirhiker
approved these changes
Dec 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
This PR addresses the following problem / context:
There are some minor errors in the implementations/updates I made recently. This PR is to fix those errors.
ThingContactAssociationshould only be added if the table object is createdwell_purposesshould be kept in the data passed toadd_thingnote_typeisHistoricalnotHistoricHow
Implementation summary - the following was changed / added / removed:
contact_special_requests_notesnotcontact_special_instructionsThingContactAssociationrecord was moved into theifstatementwell_purposeswas removed from the excluded fields in the model dump for well dataNotes
Any special considerations, workarounds, or follow-up work to note?
add_contactto reflect the name of the table where a record is being stored