Skip to content

BDMS 389: fixes#293

Merged
jirhiker merged 3 commits into
well-inventory-csvfrom
well-purposes-fix
Dec 11, 2025
Merged

BDMS 389: fixes#293
jirhiker merged 3 commits into
well-inventory-csvfrom
well-purposes-fix

Conversation

@jacob-a-brown

@jacob-a-brown jacob-a-brown commented Dec 11, 2025

Copy link
Copy Markdown
Contributor

Why

This PR addresses the following problem / context:

There are some minor errors in the implementations/updates I made recently. This PR is to fix those errors.

  • The correct field needs to be used for contact special request notes
  • A ThingContactAssociation should only be added if the table object is created
  • well_purposes should be kept in the data passed to add_thing
  • note_type is Historical not Historic

How

Implementation summary - the following was changed / added / removed:

  • The contact special requests field is named contact_special_requests_notes not contact_special_instructions
  • Adding a ThingContactAssociation record was moved into the if statement
  • well_purposes was removed from the excluded fields in the model dump for well data

Notes

Any special considerations, workarounds, or follow-up work to note?

  • I updated the name in add_contact to reflect the name of the table where a record is being stored

Fix the special request notes for a contact
Fix adding a ContantThingAssociation in contact_helper.py
Keep well_purposes in the thing data
@jirhiker jirhiker merged commit d897d0b into well-inventory-csv Dec 11, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants